Skip to content

2.3.5 p2

2.3.5-p2 Upgrade Guide

2.3.5-p2 is a security release so should be backwards compatible with the 2.3.5 branch, however it is always worth checking which files have changed in case you have any plugins / overrides / etc. interacting with the changes.

File changes

A simplified list of the files that have been changed can be generated by looking at the Magento 2 repo. GitHub make it easy to generate a patch file to look at the individual changes, see here

Alternatively, you can checkout a version of the repo locally and use git diff to see what has changed. In this release a lot of the composer files have had constraints updated, so we can filter those out, along side any changes to the tests as they should not impact the functionality of a site. Doing so gives us this list of changes

git diff --name-only 2.3.5-p1 2.3.5-p2 | grep -v composer. | grep -iv '/test' | sort
app/code/Magento/Backend/App/AbstractAction.php
app/code/Magento/Backend/Block/Widget.php
app/code/Magento/Checkout/view/frontend/web/template/summary/item/details.html
app/code/Magento/Cms/Controller/Adminhtml/Wysiwyg/Images/DeleteFolder.php
app/code/Magento/Cms/Model/Wysiwyg/Images/Storage.php
app/code/Magento/Customer/Model/Metadata/Form/Image.php
app/code/Magento/Eav/Model/Attribute/Data/File.php
app/code/Magento/ImportExport/Block/Adminhtml/Grid/Column/Renderer/Download.php
app/code/Magento/ImportExport/Block/Adminhtml/Grid/Column/Renderer/Error.php
app/code/Magento/ImportExport/Controller/Adminhtml/Export/File/Delete.php
app/code/Magento/Newsletter/Controller/Adminhtml/Template/Save.php
app/code/Magento/Quote/Setup/Patch/Data/WishlistDataCleanUp.php
app/code/Magento/Sales/Block/Adminhtml/Order/Create/Items/Grid.php
app/code/Magento/Sales/Block/Order/Creditmemo/Items.php
app/code/Magento/Sales/Block/Order/Invoice/Items.php
app/code/Magento/Sales/Setup/Patch/Data/WishlistDataCleanUp.php
app/code/Magento/Shipping/Block/Items.php
app/code/Magento/Theme/Helper/Storage.php
app/code/Magento/Theme/Model/Design/Backend/File.php
app/code/Magento/Theme/Model/Wysiwyg/Storage.php
app/code/Magento/Theme/etc/di.xml
app/code/Magento/Wishlist/Setup/Patch/Data/WishlistDataCleanUp.php
app/code/Magento/Wishlist/ViewModel/WishlistData.php
app/code/Magento/Wishlist/view/frontend/layout/default.xml
app/code/Magento/Wishlist/view/frontend/templates/sidebar.phtml
lib/internal/Magento/Framework/App/Filesystem/DirectoryList.php
lib/internal/Magento/Framework/Filesystem/Directory/Read.php
lib/internal/Magento/Framework/Filesystem/Driver/File.php

Based on the above we can see that there are changes to a checkout and wishlist template that you will need to check any themes you are using have not overwritten.

Base file changes

After the composer upgrade command has run, Magento will copy files from vendor to the Project root. Notable files that will get overwritten in this process are the index.php and pub/index.php, so if you have made any changes to these, they will need to be put back before the files are committed.

It will also overwrite files in the dev/ folder, so check to see if you have any changes there that need to be handled.